commitlog: Fix index truncation test.#2792
Merged
Merged
Conversation
Since #2771, and error is returned instead of the zero key if an offset index lookup yields the zero key. `truncate` removes the entry at its argument's key, i.e. `truncate(1)` empties the index. Adjust the `offset_index_writer_truncates_to_offset` test to handle this edge case. Also de-randomize it so all keys are tested.
Shubham8287
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #2771, and error is returned instead of the zero key if an offset
index lookup yields the zero key.
truncateremoves the entry at its argument's key, i.e.truncate(1)empties the index.
Adjust the
offset_index_writer_truncates_to_offsettest to handle thisedge case. Also de-randomize it so all keys are tested.
Expected complexity level and risk
1
Testing